Re: pgsql: Remove bogus redefinition of _MSC_VER.

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers <pgsql-committers(at)postgresql(dot)org>
Subject: Re: pgsql: Remove bogus redefinition of _MSC_VER.
Date: 2017-04-11 19:36:21
Message-ID: CABUevEwME40nigN=oVs_4FHtDurxfvcQatXtt1r1bxKkx67UWg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Thanks!

The sad thing is that I did that file manually first, the right way. Then I
realized I was going down the wrong track and made the change mechanical
instead. And forgot to change that one back..

Oops.

//Magnus

On Tue, Apr 11, 2017 at 9:32 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:

> Remove bogus redefinition of _MSC_VER.
>
> Commit a4777f355 was a shade too mechanical: we don't want to override
> MSVC's own definition of _MSC_VER, as that breaks tests on its numerical
> value. Per buildfarm.
>
> Branch
> ------
> master
>
> Details
> -------
> http://git.postgresql.org/pg/commitdiff/587d62d8562d658a2a9be60bc4574b
> 6f9e592cb1
>
> Modified Files
> --------------
> src/tools/msvc/ecpg_regression.proj | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
> --
> Sent via pgsql-committers mailing list (pgsql-committers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-committers
>

--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Magnus Hagander 2017-04-12 11:52:45 pgsql: Fix reversed check of return value from sync
Previous Message Tom Lane 2017-04-11 19:32:36 pgsql: Remove bogus redefinition of _MSC_VER.