From: | Magnus Hagander <magnus(at)hagander(dot)net> |
---|---|
To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
Cc: | Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: checkpoint_flush_after documentation inconsistency |
Date: | 2016-04-25 10:26:59 |
Message-ID: | CABUevEwG7t1xHjmPFx3ibuE5SqXGka4=MG+jjHTGbj7te005tw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Mon, Apr 25, 2016 at 6:57 AM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> On Mon, Apr 25, 2016 at 4:27 AM, Andres Freund <andres(at)anarazel(dot)de> wrote:
> > On 2016-04-21 11:20:38 -0700, Andres Freund wrote:
> >> On 2016-04-18 14:33:28 +0900, Fujii Masao wrote:
> >> > On Fri, Apr 15, 2016 at 6:56 PM, Magnus Hagander <magnus(at)hagander(dot)net>
> wrote:
> >> > > The documentation says that the default value is 128Kb on Linux,
> but the
> >> > > code says it's 256Kb.
> >> > >
> >> > > Not sure which one is correct, but the other one should be updated
> :) I'm
> >> > > guessing it's a copy/paste mistake in the docs, but since I'm not
> sure I'm
> >> > > not just pushing a fix.
> >> >
> >> > I think you're right.
> >> >
> >> > I also found another several small problems regarding XXX_flush_after
> >> > parameters.
> >>
> >> Thanks for finding these, once I'm back home/office from pgconf.nyc
> >> (tonight / tomorrow) I'll push a fix.
> >
> > Pushed a fix, could you check that you're ok with the result?
>
> The fix looks good to me. Thanks!
>
>
+1, looks good.
--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/
From | Date | Subject | |
---|---|---|---|
Next Message | Magnus Hagander | 2016-04-25 10:29:09 | Re: Ordering in guc.c vs. config.sgml vs. postgresql.sample.conf |
Previous Message | Magnus Hagander | 2016-04-25 10:17:56 | Re: Rename max_parallel_degree? |