Re: git author vs committer

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: git author vs committer
Date: 2012-09-12 17:13:01
Message-ID: CABUevEw1nvJpyzxNEBhxT7u0wzWV3BJxvDi7dhtMCbPw3b5OLQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Sep 12, 2012 at 4:21 PM, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
> A while ago I wanted to cherry-pick a patch from master to a back-branch
> that was initially committed by someone else. That was rejected because
> our git server requires author==committer. I don't think that
> restriction is particularly useful and should be lifted. I'm not saying
> we should let anyone be an author, but within the pool of committers, I
> think we should let the mechanics of the git tools determine these
> fields.

Just to be clear, what you're saying is we want to change the policy
that says "committer must be on list of approved committers &&
commiter==author" to "committer must be on list of approved committers
&& author must be on list of approved committers"?

Assuming that's what you meant, there is no support for that in the
scripts now, but if we agree that's a good thing it should be trivial
to add it.

--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2012-09-12 17:32:40 Re: 9.2 bug? "variable not found in subplan target list"
Previous Message Fujii Masao 2012-09-12 16:45:05 Re: BUG #7534: walreceiver takes long time to detect n/w breakdown