| From: | Marti Raudsepp <marti(at)juffo(dot)org> |
|---|---|
| To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | [PATCH] Minor cleanups of BRIN code |
| Date: | 2018-12-09 19:16:50 |
| Message-ID: | CABRT9RDo+W5PtGuPBrQLnC+pV1HCBYMNymJ=0y3NGcZSrwFu1w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi list,
I was messing around a bit with BRIN code and found some cleanups to be made:
1. Remove dead code in brin_form_tuple
2. Add missing Datum conversion macros
3. Use AttrNumber type in places using 1-based attribute numbers
Though it's not hard to find cases all over source code similar to (2)
and (3), are these kinds of cleanups considered useful?
Regards,
Marti Raudsepp
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-brin-Minor-cleanups-of-BRIN-code.patch | text/x-patch | 6.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Korotkov | 2018-12-09 19:25:43 | Re: Connections hang indefinitely while taking a gin index's LWLock buffer_content lock |
| Previous Message | Tom Lane | 2018-12-09 19:07:29 | Re: pg_partition_tree crashes for a non-defined relation |