| From: | Marti Raudsepp <marti(at)juffo(dot)org> |
|---|---|
| To: | gabrielle <gorthx(at)gmail(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Mark Wong <markwkm(at)gmail(dot)com>, Brent Dombrowski <brent(dot)dombrowski(at)gmail(dot)com>, Dan Colish <dan(at)unencrypted(dot)org> |
| Subject: | Re: [PATCH] Log crashed backend's query v2 |
| Date: | 2011-10-05 22:59:55 |
| Message-ID: | CABRT9RDi95t9L0iSAcsb9fKsCEpy08nwRu-0wEbeRxPRK8GATA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Oct 5, 2011 at 02:36, gabrielle <gorthx(at)gmail(dot)com> wrote:
> This review was compiled from a PDXPUG group review (Dan Colish, Mark
> Wong, Brent Dombrowski, and Gabrielle Roth).
Whaat, you marked the patch as "Returned with Feedback" based on this review?
The only obvious change I need to make in response to your feedback is
the function name fix in a comment. Most points are incorrect: there's
no regression test in this patch and no requirement of plpythonu. I
didn't introduce any new messages with the text "unknown". The
behavior of ascii_safe_strncpy is deliberate and was implemented from
feedback on the first patch version.
What's left is the indentation alignment in the if() statement. No way
is that a a reason to delay the patch to the next CommitFest!
Regards,
Marti
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2011-10-05 23:20:16 | Re: Bug with pg_ctl -w/wait and config-only directories |
| Previous Message | Alex Hunsaker | 2011-10-05 21:53:58 | alter table only ... drop constraint broken in HEAD |