From: | Marti Raudsepp <marti(at)juffo(dot)org> |
---|---|
To: | gabrielle <gorthx(at)gmail(dot)com> |
Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Mark Wong <markwkm(at)gmail(dot)com>, Brent Dombrowski <brent(dot)dombrowski(at)gmail(dot)com>, Dan Colish <dan(at)unencrypted(dot)org> |
Subject: | [PATCH] Log crashed backend's query v3 |
Date: | 2011-10-06 00:14:52 |
Message-ID: | CABRT9RB4pVD8_6+b_td-=BD29cYQ-0Jk5Y0afWtcU6Rfrza0zQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi,
My apologies for the last grumpy message I wrote; I sent it out of
surprise that my patch was marked "closed" on the current commitfest.
I hope I haven't discouraged you from reviewing this updated version.
I think you intended to use the "Waiting on Author" status -- that
leaves the commitfest entry open. I will re-open the commitfest entry
myself, I hope that's OK.
Here is version 3 of the patch.
On Wed, Oct 5, 2011 at 02:36, gabrielle <gorthx(at)gmail(dot)com> wrote:
> - The doc comment 'pgstat_get_backend_current_activity' doesn't match
> the function name 'pgstat_get_crashed_backend_activity'.
This is now fixed in the patch.
> Project coding guidelines:
> - There are some formatting problems, such as all newlines at the same
> indent level need to line up.
> - Wayward tabs, line 2725 in pgstat.c specifically
I wasn't entirely sure which line you're referring to (what's on line
2725 in the current git master wasn't touched by me)
But I presume it's this statement:
if (activity < BackendActivityBuffer || ...
I have rearranged this if statement using a temporary variable so that
there's no need to right-align long expressions anymore.
I also tweaked the wording of comments here and there.
For the points not addressed in this version, see my response here:
http://archives.postgresql.org/pgsql-hackers/2011-10/msg00202.php
Regards,
Marti
Attachment | Content-Type | Size |
---|---|---|
log-crashed-query-v3.patch | text/x-patch | 8.2 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Mr. Aaron W. Swenson | 2011-10-06 00:21:28 | Re: Bug with pg_ctl -w/wait and config-only directories |
Previous Message | Bruce Momjian | 2011-10-05 23:59:07 | Re: Bug with pg_ctl -w/wait and config-only directories |