Re: Update EnableTimeoutParams timeout type comment

From: Xuneng Zhou <xunengzhou(at)gmail(dot)com>
To: John Naylor <johncnaylorls(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Update EnableTimeoutParams timeout type comment
Date: 2026-07-02 07:02:38
Message-ID: CABPTF7X=T7Ke0RdSWdTmneUCSxTZNU5gqpuFdnsUCJ7zwriFJw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jul 2, 2026 at 2:23 PM John Naylor <johncnaylorls(at)gmail(dot)com> wrote:
>
> On Wed, Jul 1, 2026 at 11:41 AM Xuneng Zhou <xunengzhou(at)gmail(dot)com> wrote:
> > On Wed, Jul 1, 2026 at 12:01 PM John Naylor <johncnaylorls(at)gmail(dot)com> wrote:
> > > It seems pointless to have a comment whose entire content is to list
> > > every current enum member of that type. I'd just delete the comment,
> > > since it's likely to just going to get outdated again. If any other
> > > objects of type enum have this, they should get the same treatment.
> >
> > Agreed. The comment just duplicates nearby code and can easily go
> > stale again. Removing it also makes sense to me. Here's the patch with
> > the treatment.
>
> My last sentence was meant to imply that I'd rather find and remove
> all such comments, rather than fix only one and leave the rest for
> someone else to stumble across. I had Claude whip up a throwaway
> script to find candidate useless comments, and didn't see any others
> like it, only those documenting a value that can have only a subset of
> the enum values.

Sorry, I didn't get that. Thanks for investigating this.

> I've pushed your patch.

Thanks.

--
Regards,
Xuneng Zhou
HighGo Software Co., Ltd.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro Horiguchi 2026-07-02 07:04:03 Re: proposal - queryid can be used as filter for auto_explain
Previous Message Yilin Zhang 2026-07-02 07:02:37 Re:Re: Bypassing cursors in postgres_fdw to enable parallel plans