Re: Table AM callback for logical decoding support (REPACK CONCURRENTLY)

From: Xuneng Zhou <xunengzhou(at)gmail(dot)com>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Table AM callback for logical decoding support (REPACK CONCURRENTLY)
Date: 2026-11-20 09:09:17
Message-ID: CABPTF7WyCEHVx37CRfqxkeezS+wQ-+q5U3whJGBmgBVy23aYnA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Andrew,

> The test module has two AMs that copy heap's routine, one without the
> callback. heap_getnext() insists on heap's own routine, so their tables can
> have no index or TOAST table; the test shows one refused and the other past
> the check.

A small comment for the patch:

The REPACK(CONCURRENTLY) statements failed the wal-level checking with
wal_level=mininal in my testing. This seems to be the cause of
4b2aa4b39cb to move concurrent REPACK tests out of cluster.sql. Does
it make sense to follow pg_walinspect and set wal_level = replica in a
temp config for make and meson?

--
Regards,
Xuneng Zhou
HighGo Software Co., Ltd.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2026-11-20 09:27:10 Re: Report buffer access strategies in EXPLAIN
Previous Message Neil Chen 2026-11-20 08:57:52 [PATCH] psql: Complete GRANTED BY in GRANT and REVOKE