Re: BGWORKER_INTERRUPTIBLE workers are never restarted after DROP/ALTER/CREATE DATABASE

From: Xuneng Zhou <xunengzhou(at)gmail(dot)com>
To: Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>
Cc: "Aya Iwata (Fujitsu)" <iwata(dot)aya(at)fujitsu(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Michael Paquier <michael(at)paquier(dot)xyz>
Subject: Re: BGWORKER_INTERRUPTIBLE workers are never restarted after DROP/ALTER/CREATE DATABASE
Date: 2026-11-10 23:30:54
Message-ID: CABPTF7WkRNtrSE1XKb2L7ASh6+S5OPbi66fQt39dQZuXk0G91A@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Nov 11, 2026 at 3:24 AM Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com> wrote:
>
> On Tue, 10 Nov 2026, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> > This last sentence should be gone. There is no point in sticking
> > comments for things that are non-conditions to begin with. This was
> > clearly AI-generated, as the kind of things that agents like adding
> > for nothing based on solely the input provided..
>
> Eh, sorry about that, looks like I managed to skim over this comment
> without reading it properly. Removed.
>
> On Tue, 10 Nov 2026, Iwata, Aya <iwata(dot)aya(at)jp(dot)fujitsu(dot)com> wrote:
> > “A signal is sent directly to the worker so that it can be restarted according to the worker's bgw_restart_time setting.”
>
> I also edited that part.
>
> v5 is only these two comment changes compared to v3.

Thanks. LGTM except from one nit in the added line:

"A signal is sent directly to the worker so that it can be restarted
according to the worker's bgw_restart_time setting"

"can be restarted based on its bgw_restart_time and exited status"
seems to help to clarify the rule like the doc.

--
Regards,
Xuneng Zhou
HighGo Software Co., Ltd.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message João Rito 2026-11-10 23:33:31 Re: pg_upgrade fails when FK constraint with same name exists on partitioned table and its partition
Previous Message João Rito 2026-11-10 22:52:08 Re: Fix for consume_xids advancing XIDs incorrectly