Re: Implement waiting for wal lsn replay: reloaded

From: Xuneng Zhou <xunengzhou(at)gmail(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Alexander Korotkov <aekorotkov(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Peter Eisentraut <peter(at)eisentraut(dot)org>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Álvaro Herrera <alvherre(at)kurilemu(dot)de>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Michael Paquier <michael(at)paquier(dot)xyz>, jian he <jian(dot)universality(at)gmail(dot)com>, Tomas Vondra <tomas(at)vondra(dot)me>, Yura Sokolov <y(dot)sokolov(at)postgrespro(dot)ru>
Subject: Re: Implement waiting for wal lsn replay: reloaded
Date: 2026-04-07 14:29:05
Message-ID: CABPTF7Vzw62jdBLREdB_a_g63EtMsRBEmf9oP6s1TQGzHSVVjg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Apr 7, 2026 at 9:52 PM Andres Freund <andres(at)anarazel(dot)de> wrote:
>
> Hi,
>
> On 2026-04-07 16:46:29 +0300, Alexander Korotkov wrote:
> > On Tue, Apr 7, 2026, 16:18 Andres Freund <andres(at)anarazel(dot)de> wrote:
> > > On 2026-04-07 21:05:40 +0800, Xuneng Zhou wrote:
> > > > I’ve posted two patches. The first fixes the duplication issue
> > > > reported by Andres and is fairly straightforward. The second turned
> > > > out to be more complex than expected, and I’m still working through
> > > > possible solutions. Feedback or alternative approaches would be very
> > > > helpful.
> > > > I also spent some time drafting a patch to address the memory ordering
> > > > issue and will post it later.
> > >
> > > I propose quickly applying a minimal patch like the attached, to get the
> > > test
> > > performance back to normal.
> > >
> > > Will do so unless somebody protests within in one CI cycle and one coffee.
> > >
> >
> > I would be able to review them only after several hours. But +1 for
> > applying now to get rid of buildfarm slowdown.
>
> Done.

Thanks for dealing with it!

> Just to be clear, I didn't apply Xuneng's patches, just the minimal fix for
> the slowdown.
>

Ok, I don’t think that patch is in a committable state; posting it for
reference.

--
Best,
Xuneng

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2026-04-07 14:31:49 Re: enable fallthrough warnings on clang
Previous Message Jelte Fennema-Nio 2026-04-07 14:25:47 Re: meson: Make test output much more useful on failure (both in CI and locally)