| From: | Xuneng Zhou <xunengzhou(at)gmail(dot)com> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | Manu <manuelreyesbravo(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Raja Sai Pranav <rajasaipranav0(at)gmail(dot)com>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
| Subject: | Re: Add a hint to the "WAL summaries are required" errors |
| Date: | 2026-11-11 00:35:13 |
| Message-ID: | CABPTF7VzhY+JuS8v6Z4ZRXgWakAwL3idkBbaw16cYcXevjBtDA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On Tue, Nov 10, 2026 at 11:40 PM Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>
> On Wed, Nov 11, 2026 at 12:19 AM Manu <manuelreyesbravo(at)gmail(dot)com> wrote:
> > One note on the first sentence: with summarize_wal off, the request
> > fails earlier with "incremental backups cannot be taken unless WAL
> > summarization is enabled" (3 of 3), so whoever sees this hint already
> > has it enabled and the sentence can only be about the past.
>
> That seems right. So I'm ok with the following hint message for both errors.
>
> Consider using a more recent backup as the basis for this
> incremental backup,
> or taking a new full backup.
This line looks good. I also checked the other error messages in
'basebackup_incremental.c', but found none could benefit from a
similar hint. So guess this is the one.
--
Regards,
Xuneng Zhou
HighGo Software Co., Ltd.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Chao Li | 2026-11-11 00:38:46 | Re: Update comments in functions for statistics import in postgres_fdw.c |
| Previous Message | João Rito | 2026-11-10 23:48:38 | Re: Set 1s WaitLatch timeout if standby limit has expired in ResolveRecoveryConflictWithBufferPin |