| From: | Xuneng Zhou <xunengzhou(at)gmail(dot)com> |
|---|---|
| To: | Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
| Cc: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Kevin K Biju <kevinkbiju(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Add new wait event to XactLockTableWait |
| Date: | 2025-06-09 13:25:19 |
| Message-ID: | CABPTF7VK8URO9Y47nt1ys_J+M3Bxe-Rrf+TJSUbrGXJDJrXvgQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Dilip,
Thanks for looking into this!
On Mon, Jun 9, 2025 at 6:56 PM Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
> > Thanks for updating the patch! It looks good to me.
> >
> > I think we can mark it as "Ready for Committer" in the CommitFest.
> > Unless there are any objections, I'll commit it once v19 development
> opens.
>
> LGTM, except I suggest using WAIT_EVENT_XACT_COMPLETE instead of
> WAIT_EVENT_XACT_DONE. I think it sounds better.
>
I have renamed it in v3.
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-Add-new-wait-event-to-XactLockTableWait-functions.patch | application/octet-stream | 2.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Banck | 2025-06-09 13:25:22 | Re: Cleaning up historical portability baggage |
| Previous Message | Mihail Nikalayeu | 2025-06-09 12:47:18 | Re: strange perf regression with data checksums |