| From: | Xuneng Zhou <xunengzhou(at)gmail(dot)com> |
|---|---|
| To: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
| Cc: | Noah Misch <noah(at)leadboat(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Andres Freund <andres(at)anarazel(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Eisentraut <peter(at)eisentraut(dot)org>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Álvaro Herrera <alvherre(at)kurilemu(dot)de>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Michael Paquier <michael(at)paquier(dot)xyz>, jian he <jian(dot)universality(at)gmail(dot)com>, Tomas Vondra <tomas(at)vondra(dot)me>, Yura Sokolov <y(dot)sokolov(at)postgrespro(dot)ru> |
| Subject: | Re: Implement waiting for wal lsn replay: reloaded |
| Date: | 2026-08-15 03:01:25 |
| Message-ID: | CABPTF7V7AjfOxh9-+BVwa-9XpVoFQq87HsrAtg=Lv48JP8zyuQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Aug 15, 2026 at 8:01 AM Alexander Korotkov <aekorotkov(at)gmail(dot)com> wrote:
> The patchset looks good to me. I made some minor corrections.
>
> 0003 Removed extra check in WaitLSNCleanup() as deleteLSNWaiter()
> already does it.
> 0005 Improved comment about the situation on when LSN can go backwards.
Thanks for the corrections! LGTM. For patch 0005, I was initially
hesitant to add a new test module because it may seem somewhat heavy
just to test this issue. I ended up adding it after realizing that it
could also be reused to test another, as-yet-unreported issue.
I'm still wondering when it is appropriate to introduce a new test
module like this. I'm also not quite sure when a TAP test is warranted
instead of just providing a reproducer, since I spent a lot of time
designing this test. I'd like to hear your thoughts on them.
BTW, there are a few potential issues I've been investigating for a
while, but the fixes and constraints are still not entirely clear to
me, so I plan to send an off-list email about them later.
--
Regards,
Xuneng Zhou
HighGo Software Co., Ltd.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tender Wang | 2026-08-15 03:19:42 | [BUG] hstore integer overflow when constructing large values |
| Previous Message | Masahiko Sawada | 2026-08-15 01:08:01 | Re: Optimize UUID parse using SIMD |