Re: pgstattuple: Use streaming read API in pgstatindex functions

From: Xuneng Zhou <xunengzhou(at)gmail(dot)com>
To: wenhui qiu <qiuwenhuifx(at)gmail(dot)com>
Cc: Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Subject: Re: pgstattuple: Use streaming read API in pgstatindex functions
Date: 2025-10-13 11:14:37
Message-ID: CABPTF7Ue9C3YUS8ggpOJS8RMCNyqygsYsvJfnvmTqY7Ua2pTQg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Wenhui,

Thanks for looking into this.

On Mon, Oct 13, 2025 at 5:41 PM wenhui qiu <qiuwenhuifx(at)gmail(dot)com> wrote:
>
> Hi Xuneng Zhou
>
>
> > - /* Unlock and release buffer */
> > - LockBuffer(buffer, BUFFER_LOCK_UNLOCK);
> > - ReleaseBuffer(buffer);
> > + UnlockReleaseBuffer(buffer);
> > }
> Thanks for your patch! Just to nitpick a bit — I think this comment is worth keeping, even though the function name already conveys its meaning.
>

It makes sense. I'll keep it.

Best,
Xuneng

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Álvaro Herrera 2025-10-13 11:22:18 Re: Add RESPECT/IGNORE NULLS and FROM FIRST/LAST options
Previous Message Tomas Vondra 2025-10-13 11:09:20 Re: Adding basic NUMA awareness