| From: | Pavan Deolasee <pavan(dot)deolasee(at)gmail(dot)com> |
|---|---|
| To: | Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Toast issues with OldestXmin going backwards |
| Date: | 2018-04-21 14:30:10 |
| Message-ID: | CABOikdOupDfBEmh29W22CHN1d_T2hjo+xAQZhYuz_xZROfJtEQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, 21 Apr 2018 at 6:46 PM, Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>
wrote:
>
>
> So I dug into this one and it looks to me like the best approach. Here's
> a draft patch against 10-stable, if nobody can think of any showstoppers
> then I'll do the rest of the versions and commit them.
>
How does this guard against the case when the same OID gets inserted in the
toast table again, with matching lengths etc? Rare but seems possible, no?
I think we should look for a more complete solution how hard these bugs are
to detect and fix.
Thanks,
Pavan
> --
> Andrew (irc:RhodiumToad)
>
> --
Pavan Deolasee http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2018-04-21 14:57:38 | Re: Memory Leaks in query_planner in postgresql 9.4 version |
| Previous Message | Andrew Gierth | 2018-04-21 13:16:27 | Re: Toast issues with OldestXmin going backwards |