From: | Pavan Deolasee <pavan(dot)deolasee(at)gmail(dot)com> |
---|---|
To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Jaime Casanova <jaime(dot)casanova(at)2ndquadrant(dot)com>, Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Patch: Write Amplification Reduction Method (WARM) |
Date: | 2017-03-28 17:03:18 |
Message-ID: | CABOikdONymxQ3+=09PMWu4=9Zu525aPww4uMHJwgHzTjWpyY-Q@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Mar 28, 2017 at 4:07 PM, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
wrote:
>
> Noted few cosmetic issues in 0005_warm_updates_v21:
>
> 1.
> pruneheap.c(939): warning C4098: 'heap_get_root_tuples' : 'void'
> function returning a value
>
Thanks. Will fix.
>
> 2.
> + * HCWC_WARM_UPDATED_TUPLE - a tuple with HEAP_WARM_UPDATED is found
> somewhere
> + * in the chain. Note that when a tuple is WARM
> + * updated, both old and new versions are marked
> + * with this flag/
> + *
> + * HCWC_WARM_TUPLE - a tuple with HEAP_WARM_TUPLE is found somewhere in
> + * the chain.
> + *
> + * HCWC_CLEAR_TUPLE - a tuple without HEAP_WARM_TUPLE is found somewhere
> in
> + * the chain.
>
> Description of all three flags is same.
>
>
Well the description is different (and correct), but given that it confused
you, I think I should rewrite those comments. Will do.
> 3.
> + * HCWC_WARM_UPDATED_TUPLE - a tuple with HEAP_WARM_UPDATED is found
> somewhere
> + * in the chain. Note that when a tuple is WARM
> + * updated, both old and new versions are marked
> + * with this flag/
>
> Spurious '/' at end of line.
>
>
Thanks. Will fix.
Thanks,
Pavan
--
Pavan Deolasee http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2017-03-28 17:04:00 | Re: Monitoring roles patch |
Previous Message | Pavan Deolasee | 2017-03-28 17:01:47 | Re: Patch: Write Amplification Reduction Method (WARM) |