Skip site navigation (1) Skip section navigation (2)

Re: Patch: Write Amplification Reduction Method (WARM)

From: Pavan Deolasee <pavan(dot)deolasee(at)gmail(dot)com>
To: Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>
Cc: Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Patch: Write Amplification Reduction Method (WARM)
Date: 2016-12-02 12:36:33
Message-ID: CABOikdOK5PKDNcyZCH5w-cZYNx0rXxLBvoqwW4gqb8LSCqUq_A@mail.gmail.com (view raw, whole thread or download thread mbox)
Thread:
Lists: pgsql-hackers
On Fri, Dec 2, 2016 at 8:34 AM, Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>
wrote:

>
>
> On Tue, Nov 15, 2016 at 5:58 PM, Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>
> wrote:
>
>>
>>
>>
>> Yes, it is happening consistently. I ran the make installcheck. Attached
>> the regression.diffs file with the failed test.
>> I applied the previous warm patch on this commit
>> - e3e66d8a9813d22c2aa027d8f373a96d4d4c1b15
>>
>
>
> Are you able to reproduce the issue?
>
>
Apologies for the delay. I could reproduce this on a different environment.
It was a case of uninitialised variable and hence the inconsistent results.

I've updated the patches after fixing the issue. Multiple rounds of
regression passes for me without any issue. Please let me know if it works
for you.


> Currently the patch is moved to next CF with "needs review" state.
>
>
Thanks,
Pavan

-- 
 Pavan Deolasee                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

Attachment: 0001_track_root_lp_v6.patch
Description: application/octet-stream (27.2 KB)
Attachment: 0002_warm_updates_v6.patch
Description: application/octet-stream (106.7 KB)

In response to

Responses

pgsql-hackers by date

Next:From: Haribabu KommiDate: 2016-12-02 12:38:31
Subject: Re: WIP: [[Parallel] Shared] Hash
Previous:From: Haribabu KommiDate: 2016-12-02 12:29:13
Subject: Re: background sessions

Privacy Policy | About PostgreSQL
Copyright © 1996-2018 The PostgreSQL Global Development Group