| From: | Pavan Deolasee <pavan(dot)deolasee(at)gmail(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: PageIsAllVisible()'s trustworthiness in Hot Standby |
| Date: | 2012-12-12 17:31:14 |
| Message-ID: | CABOikdMH5XpZkup9zV9gNWd6MEUsZ90RJQqz_3pw4H+6G4bxMA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Dec 12, 2012 at 1:35 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Tue, Dec 4, 2012 at 12:10 PM, Pavan Deolasee
> <pavan(dot)deolasee(at)gmail(dot)com> wrote:
>> Hmm. Yeah, I do not have guts to prove that either. I'll probably write up a
>> comment for your consideration to explain why we don't trust PD_ALL_VISIBLE
>> in Hot standby for seq scans, but still trust VM for index-only scans.
>
> Sure.
>
Here is a small patch that adds comments to heap scan code explaining
why we don't trust the all-visible flag in the page, still continue to
support index-only scans on hot standby.
Thanks,
Pavan
--
Pavan Deolasee
http://www.linkedin.com/in/pavandeolasee
| Attachment | Content-Type | Size |
|---|---|---|
| hot-standby-pd-all-visible-heapscan.patch | application/octet-stream | 1.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jan Urbański | 2012-12-12 17:36:54 | Re: [PATCH] PL/Python: Add spidata to all spiexceptions |
| Previous Message | Tom Lane | 2012-12-12 15:37:00 | Re: Re: bulk_multi_insert infinite loops with large rows and small fill factors |