| From: | Pavan Deolasee <pavan(dot)deolasee(at)gmail(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
| Subject: | Re: Shmem queue is not flushed if receiver is not yet attached |
| Date: | 2022-05-30 07:06:14 |
| Message-ID: | CABOikdM365tnuQPNZfH9MuE+tU4NHMcGHEiSK-oab6SgBq5XcA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Robert,
On Tue, May 24, 2022 at 8:35 PM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>
>
> I think that this patch is basically correct, except that it's not
> correct to set mqh_counterparty_attached when receiver is still NULL.
> Here's a v2 where I've attempted to correct that while preserving the
> essence of your proposed fix.
>
This looks good to me,
>
> I'm not sure that we need a shm_mq_flush(), but we definitely don't
> have one currently, so I've also adjusted your patch to remove the
> dead prototype.
>
>
Makes sense to me.
Thanks,
Pavan
--
Pavan Deolasee
EnterpriseDB: https://www.enterprisedb..com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavan Deolasee | 2022-05-30 07:07:51 | Re: Shmem queue is not flushed if receiver is not yet attached |
| Previous Message | Michael Paquier | 2022-05-30 06:59:52 | Re: Bump MIN_WINNT to 0x0600 (Vista) as minimal runtime in 16~ |