| From: | Steven Niu <niushiji(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: relrewrite not documented at the top of heap_create_with_catalog() |
| Date: | 2025-06-16 08:51:46 |
| Message-ID: | CABBtG=dSKgbFJeNBpD5gs7r-Pye97K+V2zpBJKBkbd6Qup+ObA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi, Michael,
The change looks good to me.
I made more change based on your patch to combine the old comment.
Regards,
Steven
Michael Paquier <michael(at)paquier(dot)xyz> 于2025年6月16日周一 14:49写道：
> Hi all,
>
> While looking at the heap code, I've found that relrewrite, parameter
> used a trick to keep a link to the original relation rewritten, is not
> documented at the top of heap_create_with_catalog() contrary to all
> its other parameters.
>
> A simple patch is attached to document that.
>
> Thanks,
> --
> Michael
>
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Improve-the-comment-of-heap_create_with_catalog.patch | application/octet-stream | 3.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Evgeniy Gorbanev | 2025-06-16 08:52:08 | Re: No error checking when reading from file using zstd in pg_dump |
| Previous Message | Daniel Gustafsson | 2025-06-16 08:25:43 | Re: No error checking when reading from file using zstd in pg_dump |