Re: pg_dump: sortDumpableObjectsByTypeName() doesn't always do that

From: Jacob Champion <pchampion(at)pivotal(dot)io>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_dump: sortDumpableObjectsByTypeName() doesn't always do that
Date: 2018-08-06 20:38:27
Message-ID: CABAq_6GJsBefn4cS_6peg6UL6kbmZS4D2DzUR8gUyms7tCwrfQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Aug 6, 2018 at 12:45 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Ah, gotcha. But whether the behavior is sane or not, it'd be reproducible
> for any specific input dataset on any specific platform (unless you've got
> a quicksort that actually uses randomized pivots; but ours doesn't, and
> I think that pg_dump does use src/port/qsort.c). So that partially
> answers Andrew's question as to why we've not seen instability in the
> buildfarm's results.

I completely missed that the qsort in use was part of libpgport; that
should make it much easier to repro. We'll give it a shot.

Thanks,
--Jacob

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2018-08-06 21:04:32 Re: [report] memory leaks in COPY FROM on partitioned table
Previous Message Tom Lane 2018-08-06 19:45:49 Re: pg_dump: sortDumpableObjectsByTypeName() doesn't always do that