Re: BUG #19487: Error while executing SQL query involving XML parsing

вс, 30 авг. 2026 г. в 02:44, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>:

> Andrey Rachitskiy <pl0h0yp1(at)gmail(dot)com> writes:
> > In v2, I tried to take all the points into account and expanded the
> tests.
>
> Hmm, I think it might be better to drop
> map_sql_value_to_xml_is_immutable and just treat XMLELEMENT and
> XMLFOREST as non-immutable. Trying to be smarter adds quite a bit
> of complexity to this patch as well as long-term maintenance risk
> (ie, needing to keep map_sql_value_to_xml_is_immutable in step with
> the actual behavior of map_sql_value_to_xml; if we mess that up, the
> mistake will be very non-obvious, and these test cases are unlikely
> to catch it). For my money it's not worth it.
>

Dear Tom,

I think you're right. Fixed it in v3.

--
Regards,
Rachitskiy Andrey