From: | Ian Lawrence Barwick <barwick(at)gmail(dot)com> |
---|---|
To: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
Cc: | Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Re: [PATCH] Allow specification of custom slot for custom nodes |
Date: | 2022-11-26 11:04:55 |
Message-ID: | CAB8KJ=if+M3=GObz72hFaoCydSg_2=GLwRmu6QLtLB2L5CkXQg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
2022年11月22日(火) 5:50 Alexander Korotkov <aekorotkov(at)gmail(dot)com>:
>
> On Mon, Nov 21, 2022 at 4:34 PM Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com> wrote:
> > The following review has been posted through the commitfest application:
> > make installcheck-world: tested, passed
> > Implements feature: tested, passed
> > Spec compliant: not tested
> > Documentation: not tested
> >
> > I've looked at this patch and don't see any problems with it. It is minimally invasive, it doesn't affect functionality unless anyone (e.g. extension) sets its own slotOps in CustomScanState.
> > Furthermore, the current patch very slightly modifies patch 0b03e5951bf0 with the intention of introducing extensibility. So I think adding more extensibility regarding different tuple formats is an excellent thing to do.
> >
> > I'm going to mark it as RfC if there are no objections.
>
> Thank you for your feedback. I also don't see how this patch could
> affect anybody.
> I'm going to push this if there are no objections.
I see this was pushed (cee1209514) so have closed it in the CF app.
Thanks
Ian Barwick
From | Date | Subject | |
---|---|---|---|
Next Message | Amit Kapila | 2022-11-26 11:25:49 | Re: Avoid streaming the transaction which are skipped (in corner cases) |
Previous Message | Chris Travers | 2022-11-26 09:09:25 | Re: Add 64-bit XIDs into PostgreSQL 15 |