Quick Links

Re: POC: postgres_fdw insert batching

From:	Ian Lawrence Barwick <barwick(at)gmail(dot)com>
To:	Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>
Cc:	Amit Langote <amitlangote09(at)gmail(dot)com>, "tsunakawa(dot)takay(at)fujitsu(dot)com" <tsunakawa(dot)takay(at)fujitsu(dot)com>, "Andrey V(dot) Lepikhov" <a(dot)lepikhov(at)postgrespro(dot)ru>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject:	Re: POC: postgres_fdw insert batching
Date:	2021-01-22 05:50:49
Message-ID:	CAB8KJ=jCUuYW8eoTP=7=CJhMCc60SS_j+pG9sEFV0deHnw-V1A@mail.gmail.com
Views:	Raw Message \| Whole Thread \| Download mbox \| Resend email
Thread:
Lists:	pgsql-hackers

2021年1月21日(木) 8:00 Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>:

> OK, pushed after a little bit of additional polishing (mostly comments).
>
> Thanks everyone!
>

There's a minor typo in the doc's version of the ExecForeignBatchInsert()
declaration;
is:

TupleTableSlot **
ExecForeignBatchInsert(EState *estate,
ResultRelInfo *rinfo,
TupleTableSlot **slots,
TupleTableSlot *planSlots,
int *numSlots);

should be:

TupleTableSlot **
ExecForeignBatchInsert(EState *estate,
ResultRelInfo *rinfo,
TupleTableSlot **slots,
TupleTableSlot **planSlots,
int *numSlots);

(Trivial patch attached).

Regards

Ian Barwick

Attachment	Content-Type	Size
doc-fdw-batch-insert-fix.v1.patch	text/x-patch	490 bytes

Re: POC: postgres_fdw insert batching at 2021-02-05 01:54:15 from Ian Lawrence Barwick
Re: POC: postgres_fdw insert batching at 2021-02-05 01:55:04 from Ian Lawrence Barwick

	From	Date	Subject
Next Message	Greg Nancarrow	2021-01-22 06:02:09	Re: Parallel INSERT (INTO ... SELECT ...)
Previous Message	Masahiko Sawada	2021-01-22 05:50:20	Re: About to add WAL write/fsync statistics to pg_stat_wal view