Re: [PATCH] Add pg_get_event_trigger_ddl() function

2026年7月23日(木) 19:32 Jim Jones <jim(dot)jones(at)uni-muenster(dot)de>:
>
> On 22/07/2026 08:14, Zsolt Parragi wrote:
> >> That did cross my mind, but while "enabled" feels more natural grammatically,
> >> "enable" corresponds to the "ENABLE" clause which is to be emitted (or omitted).
> >> Except when it's "DISABLE"... I can't think of any better phrasing
> >> which is reasonably
> >> short and conveys the meaning "emit the clause which indicates the trigger is to
> >> be disabled or enabled, and if the latter in what context".
> >
> > Yeah, I agree with this reasoning, I wasn't even sure to mention this
> > or not. I only did because the ALTER EVENT TRIGGER documentation also
> > mentions "disabled", so there's some precedent of using that form.
> >
> > Keeping it "enable" is fine with me.
> >
> >
>
> Since there seems to be a consensus among all reviewers I'll mark the CF
> entry as ready for committer.

Thanks!

Attaching an updated patch version which uses DatumGetArrayTypePCopy()
instead of DatumGetArrayTypeP() (as pointed out in 1f108fc02).

Regards

Ian Barwick