| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | David Steele <david(at)pgmasters(dot)net>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com> |
| Subject: | Re: PATCH: Exclude additional directories in pg_basebackup |
| Date: | 2016-09-12 23:59:41 |
| Message-ID: | CAB7nPqTzocmZZ-=JG8xpKHY3P+0Z7KaQKTHoa8NRb-iOps9zAQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Sep 13, 2016 at 3:50 AM, Peter Eisentraut
<peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
> Add some tests. At least test that one entry from the directory list
> and one entry from the files list is not contained in the backup
> result. Testing the symlink handling would also be good. (The
> pg_basebackup tests claim that Windows doesn't support symlinks and
> therefore skip all the symlink tests. That seems a bit at odds with
> your code handling symlinks on Windows.)
The code proposed needs to support junction points on Windows so from
this side of things everything is fine. What is lacking here is
support for symlink() in perl for Windows, and that's why the tests
are skipped.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2016-09-13 00:15:46 | Re: Implement targetlist SRFs using ROWS FROM() (was Changed SRF in targetlist handling) |
| Previous Message | Vitaly Burovoy | 2016-09-12 23:59:39 | Re: identity columns |