Re: Why SyncRepWakeQueue is not static?

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Tatsuo Ishii <ishii(at)postgresql(dot)org>
Cc: PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Why SyncRepWakeQueue is not static?
Date: 2015-03-26 01:52:31
Message-ID: CAB7nPqTzgOAr+55k5rCMp71vhwzukrj_VMgxEVgAUexpi7rJ0A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Mar 26, 2015 at 10:46 AM, Tatsuo Ishii <ishii(at)postgresql(dot)org> wrote:
>> SyncRepWakeQueue (src/backend/replication/syncrep.c) is not used
>> anywhere except in the file. If there's no good reason for it, I think
>> it should be declared as a static function. Included patch does so.
>
> Fix committed/pushed from master to 9.2. 9.1 declares it as a static
> function.

Er, is that a good idea to back-patch that? Normally routine specs are
maintained stable on back-branches, and this is just a cosmetic
change.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tatsuo Ishii 2015-03-26 02:07:56 Re: Why SyncRepWakeQueue is not static?
Previous Message Kouhei Kaigai 2015-03-26 01:51:57 Re: Custom/Foreign-Join-APIs (Re: [v9.5] Custom Plan API)