Re: Patch: Add --no-comments to skip COMMENTs with pg_dump

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Simon Riggs <simon(at)2ndquadrant(dot)com>, Fabrízio Mello <fabriziomello(at)gmail(dot)com>, Robins Tharakan <tharakan(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, David Fetter <david(at)fetter(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>
Subject: Re: Patch: Add --no-comments to skip COMMENTs with pg_dump
Date: 2017-09-02 05:08:20
Message-ID: CAB7nPqTqsE7bdWyS8yd0WSmHs0hrr5HcTg=tqz+SVE333j708Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Sep 2, 2017 at 1:53 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Mon, Aug 21, 2017 at 5:30 PM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
>> Thinking ahead, are we going to add a new --no-objecttype switch every
>> time someone wants it?
>
> I'd personally be fine with --no-whatever for any whatever that might
> be a subsidiary property of database objects. We've got
> --no-security-labels, --no-tablespaces, --no-owner, and
> --no-privileges already, so what's wrong with --no-comments?
>
> (We've also got --no-publications; I think it's arguable whether that
> is the same kind of thing.)

And --no-subscriptions in the same bucket.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Noah Misch 2017-09-02 06:51:31 Re: Parallel worker error
Previous Message Michael Paquier 2017-09-02 04:57:42 Re: Function to move the position of a replication slot