| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andres Freund <andres(at)anarazel(dot)de>, Yury Zhuravlev <u(dot)zhuravlev(at)postgrespro(dot)ru>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>, Teodor Sigaev <teodor(at)sigaev(dot)ru> |
| Subject: | Re: GinPageIs* don't actually return a boolean |
| Date: | 2016-03-11 03:50:45 |
| Message-ID: | CAB7nPqTqHHicdJTwk5r3Wg=ggrJDqRor9-ByCgWEGK+9GiqqtQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Mar 10, 2016 at 11:40 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> We need to decide what to do about this. I disagree with Peter: I
> think that regardless of stdbool, what we've got right now is sloppy
> coding - bad style if nothing else. Furthermore, I think that while C
> lets you use any non-zero value to represent true, our bool type is
> supposed to contain only one of those two values. Therefore, I think
> we should commit the full patch, back-patch it as far as somebody has
> the energy for, and move on. But regardless, this patch can't keep
> sitting in the CommitFest - we either have to take it or reject it,
> and soon.
+1, I would suggest to move ahead, !! is not really Postgres-like anyway.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2016-03-11 03:59:51 | Re: GinPageIs* don't actually return a boolean |
| Previous Message | Joel Jacobson | 2016-03-11 03:49:27 | Re: [COMMITTERS] pgsql: Provide much better wait information in pg_stat_activity. |