Re: VS 2015 support in src/tools/msvc

On Sun, Mar 20, 2016 at 8:06 AM, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
>
>
> On 03/08/2016 07:40 PM, Michael Paquier wrote:
>>
>> On Wed, Mar 9, 2016 at 1:07 AM, Andrew Dunstan <andrew(at)dunslane(dot)net>
>> wrote:
>>>
>>> Michael's patch proposes to replace the use of sed to generate probes.h
>>> with
>>> the perl equivalent everywhere. That has the advantage that we keep to
>>> one
>>> script to generate probes.h, but it does impose a perl dependency.
>>
>> Good point. It did not occur to me that this would bring a hard
>> dependency for non-Windows builds. Let's keep both scripts then. The
>> attached is changed to do so.
>
>
>
> Actually, it wasn't, but I fixed it and committed it.

Ah, indeed, thanks. It looks like I have been bitten by an incorrect
rebase/cherry-pick.

> Still to do: the non-perl pieces.

The patch to address locales is the sensitive part. The patch from
Petr is taking the correct approach though I think that we had better
simplify it a bit and if possible we had better not rely on the else
block it introduces.
--
Michael