Re: subxcnt defined as signed integer in SnapshotData and SerializeSnapshotData

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Simon Riggs <simon(at)2ndquadrant(dot)com>
Cc: PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: subxcnt defined as signed integer in SnapshotData and SerializeSnapshotData
Date: 2015-05-09 12:48:03
Message-ID: CAB7nPqTi+eG=NqCX5oQHbUkBa39KaGornOBs-n6ic89-cQqu6A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, May 8, 2015 at 10:27 PM, Simon Riggs wrote:
> On 8 May 2015 at 13:02, Michael Paquier wrote:
>> I think that we should redefine subxcnt as uint32 for consistency with
>> xcnt, and remove the two assertions that 924bcf4 has introduced. I
>> could get a patch quickly done FWIW.
>
> (uint32) +1

Attached is the patch. This has finished by being far simpler than
what I thought first.
Regards,
--
Michael

Attachment Content-Type Size
20150509_subxcnt_uint.patch application/x-patch 1.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kohei KaiGai 2015-05-09 12:49:53 Re: Custom/Foreign-Join-APIs (Re: [v9.5] Custom Plan API)
Previous Message Stephen Frost 2015-05-09 11:07:59 Re: Async execution of postgres_fdw.