Re: should we add a XLogRecPtr/LSN SQL type?

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andres Freund <andres(at)2ndquadrant(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: should we add a XLogRecPtr/LSN SQL type?
Date: 2014-02-20 00:43:31
Message-ID: CAB7nPqTgMfM_cMJcD85FAOVt=ofTdF58OGpT=JBAaDwJy_YtfQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Feb 20, 2014 at 2:47 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Wed, Feb 5, 2014 at 9:26 PM, Michael Paquier
> <michael(dot)paquier(at)gmail(dot)com> wrote:
>> On Thu, Feb 6, 2014 at 3:48 AM, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
>>> On 2/5/14, 1:31 PM, Robert Haas wrote:
>>>> On Tue, Feb 4, 2014 at 3:26 PM, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
>>>>> Perhaps this type should be called pglsn, since it's an
>>>>> implementation-specific detail and not a universal concept like int,
>>>>> point, or uuid.
>>>>
>>>> If we're going to do that, I suggest pg_lsn rather than pglsn. We
>>>> already have pg_node_tree, so using underscores for separation would
>>>> be more consistent.
>>>
>>> Yes, that's a good precedent in multiple ways.
>> Here are updated patches to use pg_lsn instead of pglsn...
>
> OK, so I think this stuff is all committed now, with assorted changes.
> Thanks for your work on this.
Thanks!
Oops, it looks like I am coming after the battle (time difference does
not help). I'll be more careful to test such patches on 32b platforms
as well in the future.
Regards,
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2014-02-20 00:49:35 Re: [HACKERS] Re: pgsql: Add a GUC to report whether data page checksums are enabled.
Previous Message Tom Lane 2014-02-20 00:38:20 Re: Priority table or Cache table