| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Magnus Hagander <magnus(at)hagander(dot)net> |
| Cc: | Craig Ringer <craig(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andres Freund <andres(at)anarazel(dot)de>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Function to move the position of a replication slot |
| Date: | 2017-09-05 02:36:47 |
| Message-ID: | CAB7nPqTdRM2+LVFkYt93xg4qYN2jHEJqM_pUGMtXn1n1o8tEzA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Aug 31, 2017 at 9:19 PM, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
> PFA an updated and rebased patch.
>
> Rebased. Now named pg_advance_replication_slot. ERROR on logical slots.
> Forward only.
>
> I think that, in the end, covered all the comments?
+ if (backwards)
+ ereport(WARNING,
+ (errmsg("Not moving replication slot backwards!")));
Shouldn't this be an ERROR, mentioning the current position of the slot?
+ ereport(ERROR,
+ (errmsg("Only physical replication slots can be advanced.")));
ERRCODE_FEATURE_NOT_SUPPORTED, no?
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2017-09-05 02:51:48 | Re: Function to move the position of a replication slot |
| Previous Message | Tatsuo Ishii | 2017-09-05 02:30:28 | Re: Statement timeout behavior in extended queries |