Re: Re: [COMMITTERS] pgsql: Remove all references to "xlog" from SQL-callable functions in p

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Re: [COMMITTERS] pgsql: Remove all references to "xlog" from SQL-callable functions in p
Date: 2017-02-13 22:00:25
Message-ID: CAB7nPqTctAQZWFq1AAKCSAudj9hhXBOHDLXuZ+rcmWcQJvTpag@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Tue, Feb 14, 2017 at 2:31 AM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> On Tue, Feb 14, 2017 at 2:06 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> On Mon, Feb 13, 2017 at 11:43 AM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>>> On Fri, Feb 10, 2017 at 5:36 AM, Robert Haas <rhaas(at)postgresql(dot)org> wrote:
>>>> Remove all references to "xlog" from SQL-callable functions in pg_proc.
>>>>
>>>> Commit f82ec32ac30ae7e3ec7c84067192535b2ff8ec0e renamed the pg_xlog
>>>> directory to pg_wal. To make things consistent, and because "xlog" is
>>>> terrible terminology for either "transaction log" or "write-ahead log"
>>>> rename all SQL-callable functions that contain "xlog" in the name to
>>>> instead contain "wal". (Note that this may pose an upgrade hazard for
>>>> some users.)
>>>
>>> There are still some mentions to "xlog" in the doc. Maybe we should replace
>>> them with "wal" as the attached patch does.
>>
>> +1. Patch looks good to me.
>
> Thanks! Pushed.

It seems like the previous review I provided for the set of renaming
patches has been ignored:
https://www.postgresql.org/message-id/CAB7nPqSm=PNSe3EfvnEResdFzpQMcXXgapFBcF=EFdxVW4=fDQ@mail.gmail.com
Good that somebody else checked...
--
Michael

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2017-02-14 14:41:31 pgsql: Corrections and improvements to generic parallel query documenta
Previous Message Fujii Masao 2017-02-13 17:31:53 Re: [COMMITTERS] pgsql: Remove all references to "xlog" from SQL-callable functions in p

Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2017-02-13 22:03:43 Re: Small improvement to parallel query docs
Previous Message Brad DeJong 2017-02-13 21:56:36 Re: Small improvement to parallel query docs