|From:||Michael Paquier <michael(dot)paquier(at)gmail(dot)com>|
|To:||Nikhil Sontakke <nikhils(at)2ndquadrant(dot)com>|
|Cc:||David Steele <david(at)pgmasters(dot)net>, Stas Kelvich <s(dot)kelvich(at)postgrespro(dot)ru>, Simon Riggs <simon(at)2ndquadrant(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>, Jesper Pedersen <jesper(dot)pedersen(at)redhat(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>|
|Subject:||Re: Speedup twophase transactions|
|Views:||Raw Message | Whole Thread | Download mbox|
On Fri, Mar 17, 2017 at 5:15 PM, Michael Paquier
> On Fri, Mar 17, 2017 at 5:00 PM, Nikhil Sontakke
> <nikhils(at)2ndquadrant(dot)com> wrote:
>> Micheal, it looks like you are working on a final version of this patch? I
>> will wait to review it from my end, then.
> I have to admit that I am beginning to get drawn into it...
And here is what I got. I have found a couple of inconsistencies in
the patch, roughly:
- During recovery entries marked with ondisk = true should have their
start and end LSN reset to InvalidXLogRecPtr. This was actually
leading to some inconsistencies in MarkAsPreparing() for 2PC
transactions staying around for more than 2 checkpoints.
- RecoverPreparedTransactions(), StandbyRecoverPreparedTransactions()
and PrescanPreparedTransactions() doing both a scan of pg_twophase and
the shared memory entries was way too complicated. I have changed
things so as only memory entries are scanned by those routines, but an
initial scan of pg_twophase is done before recovery.
- Some inconsistencies in the comments and some typos found on the way.
- Simplification of some routines used in redo, as well as simplified
the set of routines made available to users.
Tests are passing for me, an extra lookup would be nice.
|Next Message||Peter Eisentraut||2017-03-22 02:12:18||Re: Updating the "tool sets" documentation for modern FreeBSD|
|Previous Message||Peter Eisentraut||2017-03-22 02:05:39||Re: Unacccented Fractions|