Re: Patch: add recovery_timeout option to control timeout of restore_command nonzero status code

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Alexey Vasiliev <leopard_ne(at)inbox(dot)ru>
Cc: Fabrízio Mello <fabriziomello(at)gmail(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Patch: add recovery_timeout option to control timeout of restore_command nonzero status code
Date: 2014-12-30 12:39:33
Message-ID: CAB7nPqT_EudYP1aV1=e+6vrJqQ9ox1qgj_2CS1RRrUB9n-bkog@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Dec 30, 2014 at 9:33 PM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
> On Tue, Dec 30, 2014 at 9:10 PM, Alexey Vasiliev <leopard_ne(at)inbox(dot)ru> wrote:
>> To not modify current pg_usleep calculation, I changed
>> restore_command_retry_interval value to seconds (not milliseconds). In this
>> case, min value - 1 second.
> Er, what the problem with not changing 1000000L to 1000L? The unit of
> your parameter is ms AFAIK.
Of course I meant in the previous version of the patch not the current
one. Wouldn't it be useful to use it with for example retry intervals
of the order of 100ms~300ms for some cases?
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Stephen Frost 2014-12-30 13:05:45 Re: Additional role attributes && superuser review
Previous Message Bernd Helmle 2014-12-30 12:35:50 Re: [HACKERS] ON_ERROR_ROLLBACK