Re: [BUG] pg_basebackup from disconnected standby fails

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>, Magnus Hagander <magnus(at)hagander(dot)net>
Subject: Re: [BUG] pg_basebackup from disconnected standby fails
Date: 2016-10-26 07:09:38
Message-ID: CAB7nPqTYTwLRhXNJk+f-0O0am+2mLXao2jt0f7sMeKiXmULbUA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Oct 26, 2016 at 1:40 PM, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> If you are inclined towards this solution, then I think what we need
> to do is to change the API UpdateMinRecoveryPoint() such that it's
> second parameter can take three values. 0 means update
> minRecoveryPoint to passed lsn if minRecoveryPoint < lsn; 1 means
> update minRecoveryPoint to latest replayed point if minRecoveryPoint <
> lsn, same as currently false for *force*; 2 indicates same behaviour
> as current *force* as true. Also we need to pass currentTLI parameter
> (lastCheckPoint.ThisTimeLineID) to this API to update
> minRecoveryPointTLI. I have not tried this, but I think something on
> these lines should work.

0 is the behavior that you get when force = false, so it works as 1, no?
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tsunakawa, Takayuki 2016-10-26 07:10:17 Re: [bug fix] Stats collector is not restarted on the standby
Previous Message Daniel Gustafsson 2016-10-26 06:52:19 Small typo in pageinspect heapfuncs