Re: Tab completion for ALTER COLUMN SET STATISTICS

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Jeff Janes <jeff(dot)janes(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Tab completion for ALTER COLUMN SET STATISTICS
Date: 2015-09-26 11:24:40
Message-ID: CAB7nPqTUFGj-a24=JbV_SYAqGwkBr6Tt8wV9Z4Edti_ZTEZaUQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Sep 26, 2015 at 7:18 AM, Jeff Janes <jeff(dot)janes(at)gmail(dot)com> wrote:
> If I have "alter table foo alter COLUMN bar SET STATISTICS" in the line
> buffer,
> it tab completes to add " TO", which is not legal.
>
> The attached patch makes it not tab complete anything at all, which is at
> least not actively misleading.
> I thought of having it complete "-1", "<integer>" so that it gives a clue
> about what is needed, but I didn't see any precedence for non-literal
> clue-giving and I did not want to try to create new precedence.

+1 for the way you are doing it in your patch.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2015-09-26 11:28:52 Re: PATCH: index-only scans with partial indexes
Previous Message Amit Kapila 2015-09-26 10:06:34 Re: Parallel Seq Scan