Re: [PATCH v2] GSSAPI encryption support

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Robbie Harwood <rharwood(at)redhat(dot)com>
Cc: PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH v2] GSSAPI encryption support
Date: 2015-09-09 06:57:38
Message-ID: CAB7nPqTQM5dfhMh6yskkt=w1032iJ8ggnJu9y+tZBmwwhzEZKw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Sep 9, 2015 at 4:12 AM, Robbie Harwood wrote:
> Michael Paquier writes:
> As promised, here's a V2 to address your issues with comments. I
> haven't heard back on the issues you found in testing, so no other
> changes are present.

Well, the issue is still here: login through gssapi fails with your
patch, not with HEAD. This patch is next on my review list by the way
so I'll see what I can do about it soon even if I am in the US for
Postgres Open next week. Still, how did you test it? I am just
creating by myself a KDC, setting up a valid credential with kinit,
and after setting up Postgres for this purpose the protocol
communication just fails.

> This means that only the last patch has changed. For convenience, I
> will therefore only provide this new patch. I have also updated the
> version available from my github.

Thanks, this looks better. I have updated my local branch by replacing
the last patch of the previous series by this one, so I'll base any
potential hacking on this one.
Regards,
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2015-09-09 07:52:40 Re: proposal: function parse_ident
Previous Message Pavel Stehule 2015-09-09 06:36:33 Re: On-demand running query plans using auto_explain and signals