| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Fabrízio Mello <fabriziomello(at)gmail(dot)com> |
| Cc: | Aleksandr Parfenov <a(dot)parfenov(at)postgrespro(dot)ru>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>, Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp> |
| Subject: | Re: [PATCH] A hook for session start |
| Date: | 2017-11-09 23:08:50 |
| Message-ID: | CAB7nPqTOP3TNQij7czR6DzpEpVBi1JKPpw52VcWviRTNkzqrBA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Nov 10, 2017 at 2:32 AM, Fabrízio de Royes Mello
<fabriziomello(at)gmail(dot)com> wrote:
> On Thu, Nov 9, 2017 at 12:09 AM, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
> wrote:
>> +++ b/src/test/modules/test_session_hooks/session_hooks.conf
>> @@ -0,0 +1 @@
>> +shared_preload_libraries = 'test_session_hooks'
>> Don't you think that this should be a GUC? My previous comment
>> outlined that. I won't fight hard on that point in any case, don't
>> worry. I just want to make things clear :)
>
> Ooops... my fault... fixed!
>
> Thanks again!!
+/* GUC variables */
+static char *session_hook_username = NULL;
This causes the module to crash if test_session_hooks.username is not
set. I would recommend just assigning a default value, say "postgres".
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2017-11-09 23:10:11 | pgsql: Add hash partitioning. |
| Previous Message | Joe Conway | 2017-11-09 22:46:13 | Re: [HACKERS] OpeSSL - PostgreSQL |