| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Fabrízio Mello <fabriziomello(at)gmail(dot)com> |
| Cc: | Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Unused macros in src/include/access/transam.h |
| Date: | 2016-04-05 23:26:23 |
| Message-ID: | CAB7nPqTMFq9Kao_9vGr_dshkUZb+CwjMOr_SA3uhDvrqRh4BQw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Apr 6, 2016 at 4:55 AM, Fabrízio de Royes Mello
<fabriziomello(at)gmail(dot)com> wrote:
> Hi all,
>
> When dealing with some patch review I've noticed there are two macro is not
> used anywhere:
>
> #define TransactionIdStore(xid, dest) (*(dest) = (xid))
> #define StoreInvalidTransactionId(dest) (*(dest) = InvalidTransactionId)
Not by the core code, perhaps they are used by extensions though. The
last bit of code using TransactionIdStore is from 2007 (282d2a03), by
the way. Still, knowing the low level of maintenance those are
requiring, it does not seem worth a compilation breakage I think.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Fetter | 2016-04-05 23:48:25 | Re: Materialized views vs. primary keys |
| Previous Message | Thomas Munro | 2016-04-05 23:21:46 | Re: Proposal: "Causal reads" mode for load balancing reads without stale data |