Re: Ignore src/tools/msvc/config.pl in code tree for MSVC compilation

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Ignore src/tools/msvc/config.pl in code tree for MSVC compilation
Date: 2014-05-12 07:07:25
Message-ID: CAB7nPqTFrhK_7ZY=Q1f__333K630d-zAT2TkBUzHUSEogxVqQA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, May 12, 2014 at 3:08 PM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
> Hi all,
>
> MSVC build uses two configuration perl files when running:
> config_default.pl and config.pl. The former is mandatory and is
> present in the code tree, while the latter can be used to override
> settings with some custom parameters. As far as I understand from the
> docs, config.pl should be used only in a custom environment and should
> never be committed. Hence, why not adding a .gitignore in
> src/tools/msvc and ignoring this file? This will prevent unfortunate
> commits that could include this file and impact the devs working on
> Windows. The patch attached does that. I think that it should be
> back-patched for consistency across branches..
Actually I am sending an updated patch as buildenv.pl enters in the
same category as config.pl.
--
Michael

Attachment Content-Type Size
0001-Ignore-config-and-buildenv-in-src-tools-msvc.patch text/plain 725 bytes

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2014-05-12 07:07:29 Re: pg_class.relpages/allvisible probably shouldn't be a int4
Previous Message Etsuro Fujita 2014-05-12 06:52:38 Re: inherit support for foreign tables