From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
---|---|
To: | Bruce Momjian <bruce(at)momjian(dot)us> |
Cc: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Szymon Guz <mabewlun(at)gmail(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: printing table in asciidoc with psql |
Date: | 2015-03-25 05:18:58 |
Message-ID: | CAB7nPqTFmO70qgexQ75AFxW=S6GrqkSD05p+s0UB=z8s15zRzQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Mar 25, 2015 at 4:52 AM, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> On Tue, Mar 24, 2015 at 11:15:33AM +0900, Michael Paquier wrote:
>> On Tue, Mar 24, 2015 at 8:44 AM, Bruce Momjian wrote:
>> > Notice the added 'l' next to the '<'. Updated patch attached. Any
>> > other issues?
>>
>> Ah, right. That's a good catch and your patch fixes the issue. Still,
>> there are problems with the tuple-only mode and the expanded mode. For
>> example using this example (wanted over-complicated):
>> create table "5 2.2+^.^" ("5 2.2+^.^" text, "4 2.2+^.^" text);
>> insert into "5 2.2+^.^" values ('5 2.2+^.^', '4 2.2+^.^');
>> insert into "5 2.2+^.^" values ('2 2.2+^.^', '3 2.2+^.^');
>> \pset format asciidoc
>
> OK, all fixed. Some of the bugs were original, but at least one was
> introduced by me. Patch attached. New output:
> test=> \x
> Expanded display is off.
> test=> \t
> Tuples only is on.
> test=> table "5 2.2+^.^" ;
>
> [options="header",cols="<l,<l",frame="none"]
> |====
> |5 2.2+^.^ |4 2.2+^.^
> |2 2.2+^.^ |3 2.2+^.^
> |====
Hm. This is still incorrect. You should remove options="header" here
or the first tuple is treated as a header in the case
non-expanded/tuple-only. Your patch removes correctly the header for
the expanded/tuple-only case though.
Regards,
--
Michael
From | Date | Subject | |
---|---|---|---|
Next Message | David Fetter | 2015-03-25 05:21:06 | Re: Exposing PG_VERSION_NUM in pg_config |
Previous Message | Kouhei Kaigai | 2015-03-25 03:59:28 | Re: Custom/Foreign-Join-APIs (Re: [v9.5] Custom Plan API) |