From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
---|---|
To: | Andreas Seltenreich <seltenreich(at)gmx(dot)de> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [sqlsmith] Crash on GUC serialization |
Date: | 2016-11-19 18:25:05 |
Message-ID: | CAB7nPqTEEv_9BfddQwZqw7BWfVGRoNQx9EBTZCTnxdTMZ1C-jw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Sat, Nov 19, 2016 at 9:51 AM, Andreas Seltenreich <seltenreich(at)gmx(dot)de> wrote:
> Michael Paquier writes:
>
>> [2. text/plain; fix-guc-string-eval.patch]
>
> I'm afraid taking care of the length computation is not sufficient.
> ISTM like it'll still try to serialize the NULL pointer later on in
> serialize_variable:
>
> ,----[ guc.c:9108 ]
> | case PGC_STRING:
> | {
> | struct config_string *conf = (struct config_string *) gconf;
> | do_serialize(destptr, maxbytes, "%s", *conf->variable);
> `----
Hm, yes. Using an empty string strikes as being the best match.
--
Michael
Attachment | Content-Type | Size |
---|---|---|
fix-guc-string-eval-v2.patch | text/plain | 848 bytes |
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2016-11-19 18:28:02 | Re: [BUG?] pg_event_trigger_ddl_commands() error with ALTER TEXT SEARCH CONFIGURATION |
Previous Message | Douglas Doole | 2016-11-19 18:17:51 | Re: possible optimizations - pushing filter before aggregation |