| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Asif Naeem <anaeem(dot)it(at)gmail(dot)com> |
| Cc: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Andreas Karlsson <andreas(at)proxel(dot)se>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pgcrypto compilation error due to stack-allocated EVP_CIPHER_CTX |
| Date: | 2016-12-06 21:23:50 |
| Message-ID: | CAB7nPqTDTjN0KCbRzj-8xZV+yxN9+k9ikNWyoOFjtDw9bv=kvQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Dec 6, 2016 at 11:42 PM, Asif Naeem <anaeem(dot)it(at)gmail(dot)com> wrote:
> Thanks for updated patch. Although EVP_CIPHER_CTX_cleanup() seems deprecated
> in OpenSSL >= 1.1.0 i.e.
>
>> # if OPENSSL_API_COMPAT < 0x10100000L
>> # define EVP_CIPHER_CTX_init(c) EVP_CIPHER_CTX_reset(c)
>> # define EVP_CIPHER_CTX_cleanup(c) EVP_CIPHER_CTX_reset(c)
>> # endif
>
>
> I guess use of deprecated function is fine, until OpenSSL library support
> it.
We could use some ifdef block with the OpenSSL version number, but I
am not sure if that's worth complicating the code at this stage.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2016-12-06 21:27:14 | Re: WIP: Faster Expression Processing and Tuple Deforming (including JIT) |
| Previous Message | Nico Williams | 2016-12-06 21:22:54 | Re: WIP: Faster Expression Processing and Tuple Deforming (including JIT) |