Re: [PATCH] Fixed malformed error message on malformed SCRAM message.

On Mon, May 29, 2017 at 2:40 PM, Alvaro Herrera
<alvherre(at)2ndquadrant(dot)com> wrote:
> Michael Paquier wrote:
>> On Mon, May 29, 2017 at 2:06 PM, Alvaro Herrera
>> <alvherre(at)2ndquadrant(dot)com> wrote:
>> > These messages look all wrong to me.
>>
>> So your complain would be to do the following for each error message
>> that uses parenthesis to include details? Like that I suppose:
>> --- a/src/backend/libpq/auth-scram.c
>> +++ b/src/backend/libpq/auth-scram.c
>> @@ -283,11 +283,13 @@ pg_be_scram_exchange(void *opaq, char *input,
>> int inputlen,
>> if (inputlen == 0)
>> ereport(ERROR,
>> (errcode(ERRCODE_PROTOCOL_VIOLATION),
>> - (errmsg("malformed SCRAM message (empty message)"))));
>> + errmsg("malformed SCRAM message"),
>> + errdetail("Empty message.")));
>
> Yeah, but along the lines of errdetail("The message is empty.")

Okay. What do you think about the attached patch then? Does it address
your concerns about the format of those error messages?
--
Michael