| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_hba_file_settings view patch |
| Date: | 2016-11-07 04:36:45 |
| Message-ID: | CAB7nPqT7wgK96JUsiFANE1EHreCV68_gArrVGJeMnkNtzQ3Dpw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Nov 7, 2016 at 12:36 PM, Haribabu Kommi
<kommi(dot)haribabu(at)gmail(dot)com> wrote:
> The added regression test fails for the cases where the server is loaded
> with
> different pg_hba.conf rules during installcheck verification. Updated patch
> is
> attached with removing those tests.
That's not a full review as I just glanced at this patch a couple of seconds...
#include "utils/guc.h"
+#include "utils/jsonb.h"
#include "utils/lsyscache.h"
You don't need to include this header when using arrays.
Implementing a test case is possible as well using the TAP
infrastructure. You may want to look at it and help folks testing the
patch more easily with a set of configurations in pg_hba.conf that
cover a maximum of code paths in your patch.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2016-11-07 04:43:22 | Re: Let's get rid of SPI_push/SPI_pop |
| Previous Message | Haribabu Kommi | 2016-11-07 03:36:18 | Re: pg_hba_file_settings view patch |