| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
| Cc: | PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: XLOG_PARAMETER_CHANGE (WAL record) missing two params in its desc routine |
| Date: | 2014-12-05 15:05:12 |
| Message-ID: | CAB7nPqT7g-myOi9rmK4yY-gw90iV=2BTmO2dORKJJp2cxapnYQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Dec 5, 2014 at 7:12 PM, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>
wrote:
> On 12/05/2014 04:54 AM, Michael Paquier wrote:
>
>> Hi all,
>>
>> While reading the code in this area this morning, I noticed that
>> wal_log_hints and track_commit_timestamp are not mentioned in the desc
>> routine of XLOG_CHANGE_PARAMETER. Also, it is not mentioned in
>> postgresql.conf.sample that a value update of wal_log_hints requires a
>> system restart.
>>
>> In order to fix those things, attached are two patches:
>> - patch 1 should be applied back to 9.4 where wal_log_hints has been added
>>
>
> You got the wal_level and wal_log_hints strings backwards:
>
Oops. Thanks for double-checking.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2014-12-05 15:05:22 | Re: advance local xmin more aggressively |
| Previous Message | Stephen Frost | 2014-12-05 15:02:56 | Re: Review of GetUserId() Usage |