Re: [COMMITTERS] pgsql: passwordcheck: Add test suite

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: passwordcheck: Add test suite
Date: 2017-09-15 04:20:07
Message-ID: CAB7nPqT6MLo7kt0RVdEuxgA4=zSZ8S6QYwTV=TSwtFUO=bbk-g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Fri, Sep 15, 2017 at 12:02 PM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
> On Fri, Sep 15, 2017 at 11:46 AM, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
>> passwordcheck: Add test suite
>>
>> Also improve one error message.
>>
>> Reviewed-by: David Steele <david(at)pgmasters(dot)net>
>
> Sorry for showing up late for this topic.
> +REGRESS_OPTS = --temp-config $(srcdir)/passwordcheck.conf
> +REGRESS = passwordcheck
> +# disabled because these tests require setting shared_preload_libraries
> +NO_INSTALLCHECK = 1
> You could have avoided all that by just issuing "load
> 'passwordcheck';" at the beginning of the test. And you gain support
> for installcheck this way.

In short you just need the attached ;)
--
Michael

Attachment Content-Type Size
0001-Simplify-new-test-suite-handling-of-passwordcheck.patch application/octet-stream 2.5 KB

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2017-09-15 04:25:36 pgsql: Avoid duplicate typedef for SharedRecordTypmodRegistry.
Previous Message Andres Freund 2017-09-15 04:11:58 Re: pgsql: Add support for coordinating record typmods among parallel worke

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2017-09-15 04:29:48 Re: pgsql: Add support for coordinating record typmods among parallel worke
Previous Message Andres Freund 2017-09-15 04:11:58 Re: pgsql: Add support for coordinating record typmods among parallel worke