Re: Re: [COMMITTERS] pgsql: Add trigonometric functions that work in degrees.

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Re: [COMMITTERS] pgsql: Add trigonometric functions that work in degrees.
Date: 2016-04-05 01:20:37
Message-ID: CAB7nPqT5bpu+BHubrqCjDW4_N1Nu3S832Kz-A7P1W9KGgsTuSw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Tue, Apr 5, 2016 at 10:16 AM, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
> On 01/22/2016 03:46 PM, Tom Lane wrote:
>>
>> Add trigonometric functions that work in degrees.
>>
>> The implementations go to some lengths to deliver exact results for values
>> where an exact result can be expected, such as sind(30) = 0.5 exactly.
>
> I have a host here that is having regression test failures from this commit:
>
> --- src/test/regress/expected/float8.out
> +++ src/test/regress/results/float8.out
> @@ -490,9 +490,9 @@
> x | asind | acosd | atand
> ------+-------+-------+-------
> -1 | -90 | 180 | -45
> - -0.5 | -30 | 120 |
> + -0.5 | | 120 |
> 0 | 0 | 90 | 0
> - 0.5 | 30 | 60 |
> + 0.5 | | 60 |
> 1 | 90 | 0 | 45
> (5 rows)
>
> Any ideas?

Likely an oversight not tracked by the buildfarm. What are you using here?
--
Michael

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2016-04-05 01:24:32 pgsql: Fix error message from wal_level value renaming
Previous Message Peter Eisentraut 2016-04-05 01:16:33 Re: [COMMITTERS] pgsql: Add trigonometric functions that work in degrees.

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2016-04-05 01:24:45 Re: Correction for replication slot creation error message in 9.6
Previous Message Peter Eisentraut 2016-04-05 01:16:33 Re: [COMMITTERS] pgsql: Add trigonometric functions that work in degrees.